Re: [PATCH] Add per-cpu indexing to /proc/timer_list

[Alexey Dobriyan]

On Tue, Nov 25, 2008 at 06:14:45PM -0500, Joe Korty wrote:
> Per-cpu indexing of /proc/timer_list.
> 
> /proc/timer_list, potentially a very large file, is in
> danger of overflowing its seq_file buffer.  So 'split up'
> the buffering on cpu ID boundaries.  This should make this
> file more likely to be useful on largish SMP systems.

What do you mean?

You can't overflow seq_file buffer unless kmalloc() will fail large
allocation. And changing internals doesn't change amount of stuff
to be shown, which is the only thing which can lead to large buffer
need.

> The model followed is that in /proc/interrupts, which
> splits up its buffering on (most) irq boundaries.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/