Re: [PATCH] random: add a way to get some random bits into theentropy pools early on

From: Ingo Molnar
Date: Tue Nov 25 2008 - 21:51:35 EST



* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> >From 5b3b09ac82316c2d4000460d586ebe59303c12c2 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> Date: Tue, 25 Nov 2008 11:41:37 -0800
> Subject: [PATCH] random: add a way to get some random bits into the entropy pools early on
>
> currently the entropy pool gets seeded on the module_init() level, but there
> is at least one consumer of random bits (the oops ID that is printed as part
> of the oops).
> As a result of this, kerneloops.org is seeing a lot of oopses that all share
> the same 'random' number; which used to get filed away as "duplicate".
>
> This patch adds a function to the random driver so that various pieces of
> the kernel can add random bits (but not entropy!) to the pool, to avoid
> this dupicate ID problem.
>
> Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> ---
> arch/x86/kernel/apic.c | 7 +++++++
> drivers/char/random.c | 29 +++++++++++++++++++++++++++++
> include/linux/random.h | 3 +++
> kernel/panic.c | 1 +
> 4 files changed, 40 insertions(+), 0 deletions(-)

good catch ...

Acked-by: Ingo Molnar <mingo@xxxxxxx>

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/