Re: [PATCH] memcg reclaim shouldn't change zone->recent_rotated statics.

[KOSAKI Motohiro]

> On Tue, 25 Nov 2008 12:22:53 +0900 (JST)
> KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx> wrote:
> 
> > +	if (scan_global_lru(sc))
> 
> mutter.  scan_global_lru() is a terrible function name.  Anyone reading
> that code would expect that this function, umm, scans the global LRU.

yup.

> gcc has a nice convention wherein such functions have a name ending in
> "_p" (for "predicate").  Don't do this :)

however, "_p" isn't linux convention.
so, I like "is_" or "can_" (or likes somethingelse) prefix :)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/