Re: [patch 5/9] x86, bts: base in-kernel ds interface on handles

From: Ingo Molnar
Date: Tue Nov 25 2008 - 11:36:49 EST



* Markus Metzger <markus.t.metzger@xxxxxxxxx> wrote:

> +static void ds_release(struct ds_tracer *tracer, enum ds_qualifier qual)
> +{
> + if (tracer->context) {
> + BUG_ON(tracer->context->owner[qual] != tracer);

please use WARN_ON_ONCE() instead of crashing the box. (this is true
in a number of other places as well in ds.c)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/