Re: [PATCH 1/1] edac x38: new MC driver module

[Hitoshi Mitake]

On Tue, 25 Nov 2008 16:46:18 +0100 (CET)
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:

> On Wed, 26 Nov 2008, Hitoshi Mitake wrote:
> > On Mon, 24 Nov 2008 21:13:58 -0800
> > "H. Peter Anvin" <hpa@xxxxxxxxx> wrote:
> > > Are you planning to add writeq() as well?
> > 
> > Yes, I want to add writeq().
> > But there's a problem that
> > I don't have a plan to use writeq() now, so I can't test writeq() soon.
> > 
> > How is this? I think it isn't bad. I want to hear your opinion.
> > 
> > static inline void writeq(__u64 val, volatile void __iomem *addr)
> > {
> > 	writel((unsigned int)val, addr);
> > 	writel((unsigned int)(val >> 32), addr+1);
>                                                ^
> 					       4
> 
> > }
> 

Thanks, I missed about void pointer...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/