Re: [PATCH] ricoh_mmc: Handle newer models of Ricoh controllers

From: Pierre Ossman
Date: Tue Nov 25 2008 - 05:45:48 EST


On Tue, 25 Nov 2008 00:42:57 -0800
Philip Langdale <philipl@xxxxxxxxx> wrote:

> The latest generation of laptops are shipping with a newer
> model of Ricoh chip where the firewire controller is the
> primary PCI function but a cardbus controller is also present.
>
> The existing code assumes that if a cardbus controller is,
> present, then it must be the one to manipulate - but the real
> rule is that you manipulate PCI function 0. This patch adds an
> additional constraint that the target must be function 0.
>
> Signed-off-by: Philip Langdale <philipl@xxxxxxxxx>
> ---

Mathias, please try to test this ASAP so that I can push it to Linus
for .28 (provided it works).

Frank, if possibly it would be useful if you could also test this on
the hardware you wrote your patch for. Just so we don't break
anything. :)

Rgds
--
-- Pierre Ossman

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.

Attachment: signature.asc
Description: PGP signature