Re: [PATCH] 8250: Eliminate compile warning of 8250.c

From: Alan Cox
Date: Tue Nov 25 2008 - 05:43:33 EST


> Can't understand initializing got "risk hiding future ones". As I know, didn't

Because if you set it to NULL and later delete a line which does the
intended assignment you will no longer get a warning.

> think BUG_ON(n==null) cover this. And I don't think leave it to compiler is
> more proper here.

The BUG_ON covers it, the current gcc gets this right and works it out.

NAK again

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/