Re: [PATCH] drivers/video/backlight: rename da903x to da903x_bl

[Mike Rapoport]

Eric Miao wrote:
> Isn't modprobe supposed to be smart enough for things like this?

Here's snap from build log:

mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ touch drivers/video/backlight/da903x.c
mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ touch drivers/regulator/da903x.c
mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $ make O=/home/mike/arm/kernel/build/pxa/  modules
  CHK     include/linux/version.h
make[2]: `include/asm-arm/mach-types.h' is up to date.
  Using /mnt/sdb1/git/linux-2.6-arm as source for kernel
  GEN     /home/mike/arm/kernel/build/pxa/Makefile
  CHK     include/linux/utsrelease.h
  SYMLINK include/asm -> include/asm-arm
  CALL    /mnt/sdb1/git/linux-2.6-arm/scripts/checksyscalls.sh
<stdin>:1097:2: warning: #warning syscall fadvise64 not implemented
<stdin>:1265:2: warning: #warning syscall migrate_pages not implemented
<stdin>:1321:2: warning: #warning syscall pselect6 not implemented
<stdin>:1325:2: warning: #warning syscall ppoll not implemented
<stdin>:1365:2: warning: #warning syscall epoll_pwait not implemented
  CC [M]  drivers/regulator/da903x.o
  CC [M]  drivers/video/backlight/da903x.o
  Building modules, stage 2.
  MODPOST 70 modules
  LD [M]  drivers/video/backlight/da903x.ko
mike@gentoodev /mnt/sdb1/git/linux-2.6-arm $

So, apparently modpost is not smart enough for things like this :)

> I'm afraid if modprobe isn't so capable, we may encounter the same
> issue with other drivers and sometimes it is not so easy for
> developers of aphasia like me to choose a better name :)
> 
> - eric
> 
> -----Original Message-----
> From: Mike Rapoport [mailto:mike@xxxxxxxxxxxxxx] 
> Sent: Tuesday, November 25, 2008 5:43 PM
> To: rpurdie@xxxxxxxxx
> Cc: Eric Miao; linux-kernel@xxxxxxxxxxxxxxx; Mike Rapoport
> Subject: [PATCH] drivers/video/backlight: rename da903x to da903x_bl
> 
> Currently both da903x backlight and voltage reulator drivers have the
> same name. Rename the backlight driver to allow use of both drivers as
> modules.
> 
> Signed-off-by: Mike Rapoport <mike@xxxxxxxxxxxxxx>
> ---
>  drivers/video/backlight/Makefile                  |    2 +-
>  drivers/video/backlight/{da903x.c => da903x_bl.c} |    0 
>  2 files changed, 1 insertions(+), 1 deletions(-)
>  rename drivers/video/backlight/{da903x.c => da903x_bl.c} (100%)
> 
> diff --git a/drivers/video/backlight/Makefile
> b/drivers/video/backlight/Makefile
> index 103427d..2d8f7cb 100644
> --- a/drivers/video/backlight/Makefile
> +++ b/drivers/video/backlight/Makefile
> @@ -18,7 +18,7 @@ obj-$(CONFIG_BACKLIGHT_OMAP1)	+= omap1_bl.o
>  obj-$(CONFIG_BACKLIGHT_PROGEAR) += progear_bl.o
>  obj-$(CONFIG_BACKLIGHT_CARILLO_RANCH) += cr_bllcd.o
>  obj-$(CONFIG_BACKLIGHT_PWM)	+= pwm_bl.o
> -obj-$(CONFIG_BACKLIGHT_DA903X)	+= da903x.o
> +obj-$(CONFIG_BACKLIGHT_DA903X)	+= da903x_bl.o
>  obj-$(CONFIG_BACKLIGHT_MBP_NVIDIA) += mbp_nvidia_bl.o
>  obj-$(CONFIG_BACKLIGHT_TOSA)	+= tosa_bl.o
>  obj-$(CONFIG_BACKLIGHT_SAHARA)	+= kb3886_bl.o
> diff --git a/drivers/video/backlight/da903x.c
> b/drivers/video/backlight/da903x_bl.c
> similarity index 100%
> rename from drivers/video/backlight/da903x.c
> rename to drivers/video/backlight/da903x_bl.c

-- 
Sincerely yours,
Mike.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/