Re: Regression: ACPI AC driver doesn't work on Toshiba Portege R500 (bisected)

[Rafael J. Wysocki]

On Tuesday, 25 of November 2008, Zhang Rui wrote:
> On Mon, 2008-11-24 at 21:30 +0800, Rafael J. Wysocki wrote:
> > On Monday, 24 of November 2008, Zhang Rui wrote:
[--snip--]
> > 
> > Do I understand correctly that you intend to revert commit
> > faee816b1502385dc9bc5abf2960d1cc645844d1 and provide an alternative patch
> > for walken?
> > 
> First, I think it's safe to revert
> commit ïfaee816b1502385dc9bc5abf2960d1cc645844d1
> because bug #10503 can not be reproduced in the upstream kernel as a
> result of another commit  49db139955d3392c6c4facf987905d0a9afed581

OK, I'll send the revert of faee816b1502385dc9bc5abf2960d1cc645844d1 to Len
later today.

> Second, if we can make sure all the pci devices won't issue any PMEs
> when the /sys/devices/.../power/wakeup files are "disabled",

It is supposed to work like this.  If it doesn't, then there is a bug that has
to be fixed.

> then I'd glad to generate another patch which always enables the PCI root
> bridge (PNP0A03) GPE, both at runtime and sleep state, just like what we do
> for the buttons.

Please go for it.

Thanks,
Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/