Re: [PATCH] ncurses based config V2

From: Sam Ravnborg
Date: Tue Nov 25 2008 - 03:10:40 EST


Hi Nir.

> >> [ ] (U)TS namespace
> >> [ ] (I)PC namespace
> >> [ ] (U)ser namespace (EXPERIMENTAL)
> >> [ ] (P)ID Namespaces (EXPERIMENTAL)
> >
> > This looks like some ancient stuff and it must be a better way to
> > show the short-cuts.
>
> This was the best I could come up with, as ncurses does not let you
> use color attributed for menu items. I'll try a different scheme,
> where the first capitalized letter is the shortcut. What do u say?

Better than the above - let me see it in action and I will judge.
I had preferred something with a colored highlight - but if ncurses
do not support that then I think first catital letter i ok.

Alternative is to use first letter in the prompt and accept the
ambiguity.

> > I would really appreciate if you could look into the above issues.
> > If you do a repost with this fixed I will try to do a proper review,
> > including code-review next time.
>
> Sure. I'll have a patch ready in a few days.

Great - loks forward to see it.

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/