Re: [RFC PATCH] slab: __GFP_NOWARN not being propagated frommempool_alloc()

[Pekka J Enberg]

On Mon, 24 Nov 2008, Miklos Szeredi wrote:
> We see page allocation failure warnings on the mempool_alloc() path.
> See this lkml posting for example:
> 
> http://lkml.org/lkml/2008/10/27/100
> 
> The cause is that on NUMA, alloc_slabmgmt() clears __GFP_NOWARN,
> together with __GFP_THISNODE and __GFP_NORETRY.  But AFAICS it really
> only wants to clear __GFP_THISNODE.
> 
> Does this patch looks good?

Yes, it does but looking at mm/slab.c history I think we want something 
like the following instead. Christoph?

P.S. First one to test it gets a fabulous prize of a Tested-by tag in the 
patch description! How cool is that?

		Pekka