Re: [PATCH 2/3] tracing/stack-tracer: fix locking

From: Ingo Molnar
Date: Sun Nov 23 2008 - 05:52:35 EST



* Török Edwin <edwintorok@xxxxxxxxx> wrote:

> + down_read(&mm->mmap_sem);
> + vma = find_vma(mm, ip);
> if (vma) {
> file = vma->vm_file;
> vmstart = vma->vm_start;
> }
> + up_read(&mm->mmap_sem);
> }
> if (file) {
> ret = trace_seq_path(s, &file->f_path);

and now it's "file" that is held without a reference and possibly
racy.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/