Re: [PATCH 5/5] CUSE: implement CUSE - Character device in Userspace

From: Tejun Heo
Date: Sat Nov 22 2008 - 03:48:55 EST


Miklos Szeredi wrote:
> On Sat, 22 Nov 2008, Tejun Heo wrote:
>> Miklos Szeredi wrote:
>>> On Thu, 20 Nov 2008, Tejun Heo wrote:
>>>> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
>>>> index 0be9245..d4dcca8 100644
>>>> --- a/include/linux/miscdevice.h
>>>> +++ b/include/linux/miscdevice.h
>>>> @@ -28,6 +28,7 @@
>>>> #define MPT_MINOR 220
>>>> #define HPET_MINOR 228
>>>> #define FUSE_MINOR 229
>>>> +#define CUSE_MINOR 230
>>> This doesn't work: device numbers have to be allocated by LANANA.
>> My last attempt at LANANA for extended devt didn't get me anywhere and
>> I'm not sure LANANA is handling miscdevice minors at all.
>
> Back then I did get the fuse device registered in LANANA database
> (http://www.lanana.org/docs/device-list/devices-2.6+.txt)

I switched it back to dynamic minor, so it's a non-issue now.

>> If you go
>> through the tree, there are quite a few duplicate allocations including
>> FUSE_MINOR. At any rate, we can definitely try LANANA.
>
> Ugh, I suppose that's my fault for not putting the definition in
> miscdevice.h (though apparently the duplicates didn't do so either).

Miscdevice minors are spread all over the place especially under archs.
I tried to move all of them into miscdevice.h but I got scared by the
dups. :-)

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/