Re: [PATCH 5/5] CUSE: implement CUSE - Character device in Userspace

[Tejun Heo]

Andrew Morton wrote:
> On Sat, 22 Nov 2008 14:05:40 +0900 Tejun Heo <tj@xxxxxxxxxx> wrote:
> 
>> Miklos Szeredi wrote:
>>> On Thu, 20 Nov 2008, Tejun Heo wrote:
>>>> diff --git a/include/linux/miscdevice.h b/include/linux/miscdevice.h
>>>> index 0be9245..d4dcca8 100644
>>>> --- a/include/linux/miscdevice.h
>>>> +++ b/include/linux/miscdevice.h
>>>> @@ -28,6 +28,7 @@
>>>>  #define MPT_MINOR		220
>>>>  #define	HPET_MINOR		228
>>>>  #define FUSE_MINOR		229
>>>> +#define CUSE_MINOR		230
>>> This doesn't work: device numbers have to be allocated by LANANA.
>> My last attempt at LANANA for extended devt didn't get me anywhere and
>> I'm not sure LANANA is handling miscdevice minors at all.
> 
> No, I don't believe that miscdev minors are handled by lanana.
> 
> otoh, we've added only one new miscdev minor since 2005.  All the new
> code is using dynamic allocation.  Readers of your changelog and code
> comments will be wondering why you didn't do so ;)

Heh.. I suppose I was too attached to the module alias thing.  I'll
switch back to dynamic minor.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/