Re: HP accelerometer: split chip handling from HP ACPI interface

[Éric Piel]

Éric Piel schreef:
> Andrew Morton schreef:
>> On Fri, 21 Nov 2008 22:21:21 +0100
>> Pavel Machek <pavel@xxxxxxx> wrote:
>>
>>> This patch splits handling between chip-specific lis3lv02d and HP/ACPI
>>> specific hp_accel.c.
>> umm, so?  What reason does anyone have for applying it?
> Here is the log I have for the (old version) of pavel's patch:
> 
> The sensor can be accessed via various buses. In particular, SPI, I²C
> and, on HP laptops, via a specific ACPI API (the only one currently
> supported). Separate this latest platform from the core of the sensor
> driver to allow support for the other bus type. The second, and more
> direct goal is actually to be able to merge this part with the
> hp-disk-leds driver, which has the same ACPI PNP number.
> 
> 
> I'll try to follow with a patch doing the merge of the hp-disk-leds
> driver, so that everything makes sense...
Actually, I mistook, Pavel also included some led stuff in this patch.
That doesn't look right, especially as the led driver is not removed!
Following are two patches (nearly all work done by Pavel) which should
make this enhancement much clearer:
- Separate the HP ACPI support from the core
- Merge the led support and with the rest of the HP ACPI support

The final semantic of these two patches should be equivalent to the one
provided by Pavel (with some Kconfig bonus).

See you,
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/