RE: [PATCH] x86: Fix interrupt leak due to migration

From: Brandeburg, Jesse
Date: Fri Nov 21 2008 - 13:32:18 EST


Matthew Wilcox wrote:
> When we migrate an interrupt from one CPU to another, we set the
> move_in_progress flag and clean up the vectors later once they're not
> being used. If you're unlucky and call destroy_irq() before the
> vectors become un-used, the move_in_progress flag is never cleared,
> which causes the interrupt to become unusable.
>
> This was discovered by Jesse Brandeburg for whom it manifested as an
> MSI-X device refusing to use MSI-X mode when the driver was unloaded
> and reloaded repeatedly.
>
> Signed-off-by: Matthew Wilcox <willy@xxxxxxxxxxxxxxx>

We did some other quick testing on this and it seems good. Thanks
and good work Matthew!

Acked-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/