Re: [PATCH 0/10] DMA-API debugging facility

From: Ingo Molnar
Date: Fri Nov 21 2008 - 12:18:45 EST



* David Woodhouse <dwmw2@xxxxxxxxxxxxx> wrote:

> On Fri, 2008-11-21 at 17:57 +0100, Joerg Roedel wrote:
> > Yes, in principle we could move most of it to generic code. There is
> > nothing architecture specific in it.
> > Anybody who prefers this to be arch/x86 before moving it to lib/?
>
> I think it's better to start off with a generic version, and test it
> on more than one architecture before feeding it upstream. That way,
> you know you aren't going to have to go back to the drawing board
> with it.

Joerg, i'd suggest to make the generic conceptual bits generic, and
add an HAVE_DMA_DEBUG_SUPPORT Kconfig bool flag to every architecture
that enables it. It needs active changes to every architecture that
supports this facility.

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/