Re: [PATCH 06/10] x86: add check code for map/unmap_sg code

From: Ingo Molnar
Date: Fri Nov 21 2008 - 11:58:54 EST



please use this nice structure init style:

> + entry->type = DMA_DEBUG_SG;
> + entry->dev = dev;
> + entry->cpu_addr = sg_virt(s);
> + entry->size = s->length;
> + entry->dev_addr = s->dma_address;
> + entry->direction = direction;

here too:

> + struct dma_debug_entry ref = {
> + .type = DMA_DEBUG_SG,
> + .dev = dev,
> + .cpu_addr = sg_virt(s),
> + .dev_addr = s->dma_address,
> + .size = s->length,
> + .direction = dir,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/