Re: [PATCH 05/45] FS-Cache: Release page->private after failed readahead [ver #41]

From: David Howells
Date: Fri Nov 21 2008 - 05:27:29 EST


Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:

> > + if (TestSetPageLocked(page))
>
> This got obsoleted by trylock_page().
>
> I don't remember why, actually.

trylock_page() throws memory barriers in there on, say, PowerPC. That's
probably necessary.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/