Re: [patch] x86, bts: fix unlock problem in ds.c

From: Ingo Molnar
Date: Thu Nov 20 2008 - 16:48:30 EST



* stephane eranian <eranian@xxxxxxxxxxxxxx> wrote:

> Markus,
>
> I think this patch is not quite right. You don't want to go out via
> out_unlock because you're going to call ds_put_context)() when you
> did not invoke the matching ds_get_context() (hidden in
> ds_alloc_context). It happens later in the ds_request() function.

i noticed that, and fixed it via:

10db4ef: x86, PEBS/DS: fix code flow in ds_request()

can you still see problems with it?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/