Re: [PATCH 1/2] protect /sbin/init from unwanted signals more

From: Oleg Nesterov
Date: Thu Nov 20 2008 - 15:23:55 EST


On 11/20, Oleg Nesterov wrote:
>
> On 11/19, Roland McGrath wrote:
> >
> > The effect is fine, but that seems like a kludgey way to do it.
>
> Agreed, that is why I did the next patch to kill the ugliness.
>
> > I really don't think the sigaction case matters--certainly it will never
> > come up with SIGKILL.
>
> Yes. This patch doesn't affect sigaction, the next one adds a very

(this one, not the next one)

> minor side effect: init drops pending !sig_kernel_ignore() signals
> if it does sigaction(SIG_IGN). But this has nothing to do with SIGKILL
> of course.

Ah sorry, now I see I misunderstood you...

You mean, we shouldn't touch the sigaction() path. Now I am wondering
if it is really OK to drop signals if init does sigaction(SIG_DFL),
perhaps you are right.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/