Re: [PATCH 20/26] 8250: Serial driver changes to support futureCavium OCTEON serial patches.

From: Alan Cox
Date: Thu Nov 20 2008 - 15:02:59 EST


On Tue, 18 Nov 2008 14:24:14 -0800
David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote:

> In order to use Cavium OCTEON specific serial i/o drivers, we first
> patch the 8250 driver to use replaceable I/O functions. Compatible
> I/O functions are added for existing iotypeS.
>
> An added benefit of this change is that it makes it easy to factor
> some of the existing special cases out to board/SOC specific support
> code.
>
> The alternative is to load up 8250.c with a bunch of OCTEON specific
> iotype code and bug work-arounds.

Neither are pretty but this looks the better option I agree. Only niggle
is the use of "_fn" - Linux generally doesn't put types into variable
names.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/