Re: [PATCH 2.6.28-rc5 04/11] kmemleak: Add modules support

[Ingo Molnar]

small nit:

> +#else
> +static inline void memleak_load_module(struct module *mod, Elf_Ehdr *hdr,
> +				       Elf_Shdr *sechdrs, char *secstrings)
> +{ }
> +#endif

this looks nicer:

static inline void
memleak_load_module(struct module *mod, Elf_Ehdr *hdr, Elf_Shdr *sechdrs,
		    char *secstrings)
{
}

We dont use "{ }" in other places in the kernel, so lets not invent a 
new style if possible.

> +	/* the pointer to this block is stored in the module structure
> +	 * which is inside the block. Just mark it as not being a
> +	 * leak */

Comment style.

> +	/* the pointer to this block is stored in the module structure
> +	 * which is inside the block. This block doesn't need to be
> +	 * scanned as it contains data and code that will be freed
> +	 * after the module is initialized */

ditto.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/