Re: [PATCH 0/2 v3] SGI RTC: add clocksource/clockevent driver andgeneric timer vector

From: Ingo Molnar
Date: Thu Nov 20 2008 - 05:00:21 EST



* Dimitri Sivanich <sivanich@xxxxxxx> wrote:

> The following patches provide a driver for synchronized RTC
> clocksource and clockevents for SGI systems, as well as a generic
> timer system interrupt.
>
> With these patches, a module can be installed that registers the
> system-wide synchronized RTC clocksource and timers as both a
> clocksource and clockevents device running in high resolution mode.
>
> [PATCH 1/2 v3] SGI RTC: add clocksource driver
> [PATCH 2/2 v3] SGI RTC: add generic timer system interrupt

Looks very clean and well-done to me.

I had to take a good look at the rtc_timer_head->expires[] construct -
but i guess that's the best approach, as the max number of entries is
hard to judge at build time. (and we wont get any real limit
protection from gcc anyway)

Thomas, any objections?

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/