Re: [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2

[Ingo Molnar]

* Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx> wrote:

> Yinghai Lu wrote:
> > Ingo Molnar wrote:
> >> hm, one of my testboxes is rather unhappy about your patch:
> > 
> > 
> > please check
> > 
> > if you agree, will update update_genapic to autodetect other functions or etc.
> > 
> > YH
> > 
> > ---
> > 
> > [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 - fix
> > 
> > Impact: fix wakeup_secondary_cpu with hotplug
> > 
> > We can not put that in x86_quirks, because that is __initdata.
> > So try to move that to genapic, and add update_genapic in x86_quirks.
> > 
> > later we even could use that stub to
> > 1. autodetect CONFIG_ES7000_CLUSTERED_APIC
> > 2. more correct inquire_remote_apic with apic_verbosity setting.
> 
> Hi,
> 
> I encountered boot failure on x86_32 box.
> I think setting wakeup_cpu is missing.
> 
> --------
> From: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
> Subject: [PATCH] x86: genapic: fix missing wakeup_cpu setup
> 
> Impact: fix boot failure
> 
> There is no way to setup wakeup_cpu when boot parameter apic= is not passed.
> 
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@xxxxxxxxxxxxx>
> ---
>  arch/x86/mach-generic/probe.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

thanks - i've applied the wider fix from Yinghai - see it below.

i'm wondering why my tests didnt trigger this boot crash. What makes 
your system or .config special to trigger it?

	Ingo

-------------->