Re: [PATCH 2/2] simplify sig_ignored() pathes

From: Roland McGrath
Date: Wed Nov 19 2008 - 13:55:05 EST


> The code which checks for ignored signals is a bit overcomplicated
> because tracehook_consider_ignored_signal() wants the "handler" arg.
> Can't we kill it? It is not used even with utrace, and even if it will
> be used later it is OK to read ->sighand again in the slow path.

Yeah, it's fine to kill the arg. For consistency, change
tracehook_consider_fatal_signal to match. They are specified as called
with the siglock held, so it will indeed be easy and safe to check
->sighand if tracing code wants to distinguish the cases in the future.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/