Re: [PATCH] genrtc: disable genrtc on Blackfin systems

From: Andrew Morton
Date: Wed Nov 19 2008 - 01:26:59 EST


On Tue, 18 Nov 2008 15:00:15 +0800 Bryan Wu <cooloney@xxxxxxxxxx> wrote:

> From: Mike Frysinger <vapier.adi@xxxxxxxxx>
>
> Signed-off-by: Mike Frysinger <vapier.adi@xxxxxxxxx>
> Signed-off-by: Bryan Wu <cooloney@xxxxxxxxxx>

What is the reason for this change?

> diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig
> index 43d6ba8..a92a60a 100644
> --- a/drivers/char/Kconfig
> +++ b/drivers/char/Kconfig
> @@ -814,7 +814,7 @@ config JS_RTC
>
> config GEN_RTC
> tristate "Generic /dev/rtc emulation"
> - depends on RTC!=y && !IA64 && !ARM && !M32R && !MIPS && !SPARC && !FRV && !S390 && !SUPERH && !AVR32
> + depends on RTC!=y && !IA64 && !ARM && !M32R && !MIPS && !SPARC && !FRV && !S390 && !SUPERH && !AVR32 && !BLACKFIN

Gawd that's stupid. It'd be much better to add a new
CONFIG_ARCH_SUPPORTS_GENRTC in arch/*/Kconfig.

Oh well. I suppose we can run with this patch for now. Once we know
what it's for.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/