Re: chris: struct device - replace bus_id with dev_name(),dev_set_name()

From: Greg KH
Date: Mon Nov 17 2008 - 18:48:25 EST


On Fri, Nov 07, 2008 at 01:01:36PM +0100, Jesper Nilsson wrote:
> On Fri, Nov 07, 2008 at 01:38:40AM +0100, Kay Sievers wrote:
> > This patch is part of a larger patch series which will remove
> > the "char bus_id[20]" name string from struct device. The device
> > name is managed in the kobject anyway, and without any size
> > limitation, and just needlessly copied into "struct device".
>
> Thanks, but I think that since this driver has been broken a long time
> it is high time to fix it, and I think the fix removes the need for your patch.
>
> Greg, could you please look this patch over?
>
>
> [CRISv32] Fix IOP fw-loader to use platform_device.
>
> Change IOP fw-loader to use platform_device instead of
> raw device, which should be more correct usage.
>
> Signed-off-by: Stefan Andersson <stefan.andersson@xxxxxxxx>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@xxxxxxxx>

Looks sane to me. Want me to take it through my tree, or will you be
submitting it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/