Re: [PATCH] leds: Fix locking for WM8350

From: Mark Brown
Date: Mon Nov 17 2008 - 18:05:43 EST


On Mon, Nov 17, 2008 at 03:33:15PM +0000, Richard Purdie wrote:

> I've not looked in detail at the code but it looks like a maximum of a
> 32 bit value where you don't actually care which write succeeds as long
> as it takes one of the values written? I don't see why that particular

Pretty much (it's an enum led_brightness) - it's just a standard LED
that can't be written without taking interrupts along the lines of the
GPIO LED driver.

> variable needs any locking or to be atomic?

I'd certainly be surprised if it were an issue in any practical system.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/