Re: [PATCH] Fix kunmap() argument in sg_miter_stop

From: Linus Torvalds
Date: Mon Nov 17 2008 - 13:17:13 EST




On Mon, 17 Nov 2008, Jens Axboe wrote:
>
> Any opinions on the kunmap/kunmap_atomic pointer checking? It's a bit
> ugly that we have to enforce a void * rule for kunmap_atomic(),

I don't think that's a "bit ugly". I think it's unacceptable.

Making sure we pass in "struct page" to kunmap() sounds good, but the
kunmap_atomic() part just sounds insane.

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/