Re: [PATCH] leds: Add WM8350 LED driver

[Frederik Deweerdt]

Hello Mark,

On Mon, Nov 17, 2008 at 02:52:09PM +0000, Mark Brown wrote:
[...]
> +/* Microamps */
> +static const int isink_cur[] = {
[...]
> +	223191
> +};
> +
[...]
> +	for (i = 0; i < ARRAY_SIZE(isink_cur); i++)
> +		if (isink_cur[i] >= pdata->max_uA)
> +			break;
> +	led->max_uA_index = i;
> +	if (pdata->max_uA != isink_cur[i])
                                      ^^^
I may be missing something but isn't the code doing an off-by-one here
if pdata->max_uA > 223191 ?

Regards,
Frederik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/