[PATCH 2/3] account_steal_time: kill the unneededaccount_group_system_time()

From: Oleg Nesterov
Date: Mon Nov 17 2008 - 08:39:53 EST


I don't actually understand account_steal_time() and I failed to find the
commit which added account_group_system_time(), but this looks bogus.
In any case rq->idle must be single-threaded, so it can't have ->totals.

Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>

--- K-28/kernel/sched.c~ACCT_STEAL_KILL_GACCT 2008-11-10 13:05:09.000000000 +0100
+++ K-28/kernel/sched.c 2008-11-16 23:40:05.000000000 +0100
@@ -4198,7 +4198,6 @@ void account_steal_time(struct task_stru

if (p == rq->idle) {
p->stime = cputime_add(p->stime, steal);
- account_group_system_time(p, steal);
if (atomic_read(&rq->nr_iowait) > 0)
cpustat->iowait = cputime64_add(cpustat->iowait, tmp);
else

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/