Re: [PATCH] stop_machine: fix race with return value (fixes Bug#11989)

From: Heiko Carstens
Date: Mon Nov 17 2008 - 04:46:31 EST


On Mon, Nov 17, 2008 at 08:22:18AM +1030, Rusty Russell wrote:
> Bug #11989: Suspend failure on NForce4-based boards due to chanes in stop_machine
>
> We should not access active.fnret outside the lock; in theory the next
> stop_machine could overwrite it.
>
> Signed-off-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
> Tested-by: "Rafael J. Wysocki" <rjw@xxxxxxx>
> ---
> kernel/stop_machine.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

Thank you, Rusty, for finding and fixing this one as well!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/