Re: [PATCH 3/4] tracing/branch-tracer: Fix a trace recursion onbranch tracer

[Ingo Molnar]

* Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:

> Impact: Make the branch tracer use raw irq save/restore
> 
> When the branch tracer inserts an event through 
> probe_likely_condition(), it calls local_irq_save() and then results 
> in a trace recursion.
> 
> local_irq_save() -> trace_hardirqs_off() -> trace_hardirqs_off_caller()
> 	-> unlikely()
> 
> The trace_branch.c file is protected by DISABLE_BRANCH_PROFILING but 
> that doesn't prevent from external call to functions that use 
> unlikely().
> 
> My box crashed each time I tried to set this tracer (sudden and hard 
> reboot).

So this patch fixes that problem, or are there other problems left?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/