Re: [PATCH] Fix kunmap() argument in sg_miter_stop

From: Tejun Heo
Date: Sun Nov 16 2008 - 00:16:50 EST


Arjan van de Ven wrote:
> From 979d181d6199f639ba78c5eadf85857f6a9f3f89 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
> Date: Sat, 15 Nov 2008 11:23:58 -0800
> Subject: [PATCH] Fix kunmap() argument in sg_miter_stop
>
> kunmap() takes as argument the struct page that orginally got kmap()'d,
> however the sg_miter_stop() function passed it the kernel virtual address
> instead, resulting in weird stuff.
>
> Somehow I ended up fixing this bug by accident while looking for a bug
> in the same area.
>
> Reported-by: kerneloops.org
> CC: htejun@xxxxxxxxx
>
> Signed-off-by: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>

Argh... talk about confusing interfaces. Thanks a lot.

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/