Re: [PATCH 1/1 v2] HID: don't grab devices with no input

From: Jiri Kosina
Date: Fri Nov 14 2008 - 08:09:19 EST


On Fri, 14 Nov 2008, Andi Kleen wrote:

> > > Some devices have no input interrupt endpoint. These won't be
> > > handled by usbhid, but currently they are not refused and reside on
> > > hid bus. Perform this checking earlier so that we refuse to control
> > > such a device early enough (and not pass it to the hid bus at all).
> > > Signed-off-by: Jiri Slaby <jirislaby@xxxxxxxxx>
> > As the patch is obviously correct(tm) :) I have queued it in my tree, but
> > Andi, please still report back whether it fixes the issue you are seeing.
> sispm works again with that patch. Thanks.

Thanks a lot for testing.

> The only nit I noticed is that the error message seems to miss an \n

That I have already fixed in my tree.

Thanks,

--
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/