Re: [PATCH 1/2] mm: implement remap_pfn_range with apply_to_page_range

[Jeremy Fitzhardinge]

Johannes Weiner wrote:
> > -	do {
> > -		BUG_ON(!pte_none(*pte));
> >     
>
> Dropping by intention?
>   

Hm, I couldn't really see the point.   But I didn't really want to 
introduce any functional changes with this patch, so I'll add it back.

> > 	BUG_ON(addr >= end);
> > -	pfn -= addr >> PAGE_SHIFT;
> > -	pgd = pgd_offset(mm, addr);
> > -	flush_cache_range(vma, addr, end);
> >     
>
> Was the flushing redundant?  I can't spot it reappearing anywhere.

I guess its needed for virtually indexed cache architectures; I'll add 
it back.

Thanks for reviewing.

   J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/