Re: [PATCH linux-next] : Tree for November 12 (libcrc32c)

[Herbert Xu]

On Wed, Nov 12, 2008 at 01:01:05PM -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> libcrc32c uses CRYPTO interfaces so it should depend on CRYPTO.
> 
> crypto/built-in.o: In function `crc32c_mod_init':
> crc32c.c:(.init.text+0xc): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `crc32c_mod_fini':
> crc32c.c:(.exit.text+0xc): undefined reference to `crypto_unregister_shash'
> lib/built-in.o: In function `crc32c':
> (.text+0xfcf9): undefined reference to `crypto_shash_update'
> lib/built-in.o: In function `libcrc32c_mod_init':
> libcrc32c.c:(.init.text+0x666): undefined reference to `crypto_alloc_shash'
> lib/built-in.o: In function `libcrc32c_mod_fini':
> libcrc32c.c:(.exit.text+0xc): undefined reference to `crypto_free_tfm'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Thanks, I've fixed it as follows:

commit d9cc217c79df50f9a9f7937aeaa54d89ae198686
Author: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date:   Thu Nov 13 22:05:13 2008 +0800

    libcrc32c: Select CRYPTO in Kconfig
    
    Selecting CRYPTO_CRC32C is not enough as CRYPTO which CRYPTO_CRC32C
    depends on may be disabled.  This patch adds the select on CRYPTO.
    
    Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

diff --git a/lib/Kconfig b/lib/Kconfig
index d09edb7..963009a 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -64,6 +64,7 @@ config CRC7
 
 config LIBCRC32C
 	tristate "CRC32c (Castagnoli, et al) Cyclic Redundancy-Check"
+	select CRYPTO
 	select CRYPTO_CRC32C
 	help
 	  This option is provided for the case where no in-kernel-tree

-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/