Re: [PATCH] led: simplify led_trigger_register_simple

From: Anton Vorontsov
Date: Thu Nov 13 2008 - 07:03:24 EST


On Thu, Nov 13, 2008 at 05:09:13AM +0200, Felipe Balbi wrote:
> From: Felipe Balbi <felipe.balbi@xxxxxxxxx>
>
> We can make led_trigger_register_simple by returning a
> struct led_trigger *, instead of passing a struct led_trigger **
> as a parameter and changing it inside the function.
>
> Cc: Anton Vorontsov <cbou@xxxxxxx>
> Cc: David Woodhouse <dwmw2@xxxxxxxxxxxxx>
> Cc: Greg KH <greg@xxxxxxxxx>
> Cc: Pierre Ossman <drzeus@xxxxxxxxx>
> Cc: Richard Purdie <rpurdie@xxxxxxxxxxxxxxx>
> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
> ---
> Note that I could only test ide, power_supply and mmc changes with my laptop.
> The other changes weren't tested.
>
> drivers/leds/led-triggers.c | 25 ++++++++++++++---------
> drivers/leds/ledtrig-ide-disk.c | 6 ++++-
> drivers/mmc/core/host.c | 4 ++-
> drivers/mtd/nand/nand_base.c | 5 +++-
> drivers/power/power_supply_leds.c | 36 ++++++++++++++++++++++++++++------

For power supply bits:

Acked-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx>

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/