Re: [PATCH 0/2] unlikely profiler and tracer

[Steven Rostedt]

On Wed, 12 Nov 2008, Ingo Molnar wrote:
> two more small details i noticed:
> 
>  - does it do proper self-test? It doesnt seem so at first sight.

Hmm, no. The problem is that it is a switch to be added to other tracers.
There's not a branch profiling tracer itself. I could add one that just 
does that, and that could do the self test.

> 
>  - i'd suggest a rename patch that does UNLIKELY_PROFILE => BRANCH_PROFILING.
> 
>     [ 'to profile' is the verb we use generally (it's a noun too but 
>        we tend to use 'profiling' for that in other places of the
>        kernel) - so we already have CONFIG_PROFILING, etc. ]

I have no hard feelings on its name. Branch profiling is fine with me.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/