Re: [PATCH] ttusb-budget: make it depend on PCI

[Andi Kleen]

Arnd Bergmann <arnd@xxxxxxxx> writes:

> On Wednesday 12 November 2008, Mike Frysinger wrote:
>> From: 
>> Mike Frysinger <vapier@xxxxxxxxxx>
>>   To: 
>> v4l-dvb-maintainer@xxxxxxxxxxx, linux-dvb@xxxxxxxxxxx, Holger Waechtler <holger@xxxxxxxxxxxxxx>
>>   CC: 
>> Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx
>>   Date: 
>> Today 13:00:18
>>   Â
>> Since dvb-ttusb-budget.c relies on pci_alloc_consistent and
>> pci_free_consistent, make it depend on PCI in Kconfig.
>> 
>> Signed-off-by: Mike Frysinger <vapier@xxxxxxxxxx>
>
> Shouldn't you just convert it (trivially) to dma_alloc_coherent and
> dma_alloc_coherent?

Unless it really needs to use the 16MB DMA zone (which I doubt
especially for USB devices) then it should not call either with a NULL
device argument.

-Andi

-- 
ak@xxxxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/