Re: Queue upcall locking (was: [dm-devel] [RFC][PATCH] fixdm_any_congested() to properly sync up with suspend code path)

From: Christoph Hellwig
Date: Tue Nov 11 2008 - 13:22:21 EST


On Mon, Nov 10, 2008 at 09:40:18AM -0500, Mikulas Patocka wrote:
> > - If the device is suspended, the response should be that it is
> > congested, I'd have thought.
>
> Yes, but these congestion upcalls are used only for optimization and the
> device is suspended for so small time, that it doesn't matter if we
> optimize io acces in small moment or not.

We use device congested to not block pdflush on a device that can't
currently accept I/O. For a suspended device congested is always
correct, pdflush will just come back a little later and in the mean time
write out stuff that doesn't delay it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/