RE: [E1000-devel] [PATCH] igb: Reinitialize tx/rx ring count onresume

From: Duyck, Alexander H
Date: Fri Nov 07 2008 - 17:55:26 EST


Darrick J. Wong wrote:
> When suspending the device, adapter->[tr]x_ring structures are freed.
> Upon resume, these two pointers are reallocated but
> adapter->[tr]x_ring->count is not set to any value. This causes
> igb_setup_tx_resources to fail on zero-sized buffers and thus the NIC
> doesn't come back up.

This patch is a good start, but it ends up resetting the ring sizes on a suspend/resume which we really shouldn't be doing. I will see about pushing a patch with the ring sizes moved up into the adapter struct. This should help to resolve the issue and maintain the ring count through suspend/resume.

Thanks,

Alex--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/