Re: [PATCH-ugly] kmemtrace: casting a gfp_t requires __force

[Harvey Harrison]

On Fri, 2008-11-07 at 14:38 -0500, Mathieu Desnoyers wrote:
> I think a cast
> 
> (__force unsigned) could be required for checker ?

No, that's not the way bitwise works.  Printk will treat it as an
unsigned it just fine.  bitwise will only warn if you treat the value
as anything other than a bitmask (| & ^) will be fine as long as it
is done with another gfp_t....all the arithmatic operators +-* etc
will warn.

The following looks like the correct way to fix this.

From: Harvey Harrison <harvey.harrison@xxxxxxxxx>
Subject: [PATCH] kmemtrace: gfp_t is an unsigned int, not an unsigned long

Signed-off-by: Harvey Harrison <harvey.harrison@xxxxxxxxx>
---
 include/linux/kmemtrace.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/kmemtrace.h b/include/linux/kmemtrace.h
index 5bea8ea..80e9a7a 100644
--- a/include/linux/kmemtrace.h
+++ b/include/linux/kmemtrace.h
@@ -31,10 +31,10 @@ static inline void kmemtrace_mark_alloc_node(enum kmemtrace_type_id type_id,
 					     int node)
 {
 	trace_mark(kmemtrace_alloc, "type_id %d call_site %lu ptr %lu "
-		   "bytes_req %lu bytes_alloc %lu gfp_flags %lu node %d",
+		   "bytes_req %lu bytes_alloc %lu gfp_flags %u node %d",
 		   type_id, call_site, (unsigned long) ptr,
 		   (unsigned long) bytes_req, (unsigned long) bytes_alloc,
-		   (unsigned long) gfp_flags, node);
+		   gfp_flags, node);
 }
 
 static inline void kmemtrace_mark_free(enum kmemtrace_type_id type_id,
-- 
1.6.0.3.756.gb776d



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/