Re: [PATCH-ugly] kmemtrace: casting a gfp_t requires __force

From: Harvey Harrison
Date: Fri Nov 07 2008 - 14:22:52 EST


On Fri, 2008-11-07 at 22:20 +0300, Alexey Dobriyan wrote:
> On Fri, Nov 07, 2008 at 10:58:41AM -0800, Harvey Harrison wrote:
> > --- a/include/linux/kmemtrace.h
> > +++ b/include/linux/kmemtrace.h
> > @@ -34,7 +34,7 @@ static inline void kmemtrace_mark_alloc_node(enum kmemtrace_type_id type_id,
> > "bytes_req %lu bytes_alloc %lu gfp_flags %lu node %d",
> > type_id, call_site, (unsigned long) ptr,
> > (unsigned long) bytes_req, (unsigned long) bytes_alloc,
> > - (unsigned long) gfp_flags, node);
> > + (__force unsigned long)gfp_flags, node);
>
> gfp_t is "unsigned int" actually. These casts are bogus.
>
> Subject: How do I printk <type> correctly?
>
> If variable is of Type use printk format specifier.
> ---------------------------------------------------------
> int %d or %x
> unsigned int %u or %x
> long %ld ot %lx
> unsigned long %lu or %lx
> long long %lld or %llx
> unsigned long long %llu or %llx
> size_t %zu or %zx
> ssize_t %zd or %zx
>

Perhaps add gfp_t to the list ;-)

Thanks.

Harvey

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/