Re: linux-2.6.28-rc2 regression : oprofile doesnt work anymore ?

From: Robert Richter
Date: Fri Nov 07 2008 - 11:27:43 EST


On 07.11.08 14:02:49, Andi Kleen wrote:
>
> Can you please test this patch and see if it solves the problem?
>
> Thanks,
> -Andi
>
> ---
>
> oprofile: Fix p6 counter overflow check
>
> Fix the counter overflow check for CPUs with counter width > 32
>
> I had a similar change in a different patch that I didn't submit
> and I didn't notice the problem earlier because it was always
> tested together.
>
> Signed-off-by: Andi Kleen <ak@xxxxxxxxxxxxxxx>

Andi,

your patch fixes the initial bug that stops sampling immediately after
starting. The issue Eric mentions seems to be a different problem. I
am also not able to reproduce this. Your patch on top of rc3 continues
sampling at least for several minutes.

I will apply your fix.

Thanks Andi,

-Robert

--
Advanced Micro Devices, Inc.
Operating System Research Center
email: robert.richter@xxxxxxx

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/