Re: [PATCH] sched: rewrite SCHED_CPUMASK_ALLOC

From: Ingo Molnar
Date: Fri Nov 07 2008 - 04:31:19 EST



* Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:

> Sorry, you are right - keep the SCHED_CPUMASK_DECLARE() macro please.
> >
> > But the other macros can become an inline function just fine, correct?
> >
>
> Yes, but sched_cpumask_alloc() should be declared this way:
> void sched_cpumask_alloc(struct **allmasks)
> but not:
> struct *allmasks sched_cpumask_alloc(void)
>
> Because the latter is not workable for <128 CPUs case.
>
> (patch is based on [PATCH] sched: fix memory leak in a failing path)

applied to tip/sched/core, thanks!

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/