Re: [PATCH] x86: call machine_shutdown and stop all CPUs innative_machine_halt

[Ingo Molnar]

* Ivan Vecera <ivecera@xxxxxxxxxx> wrote:

> Ingo Molnar wrote:
> > the code in arch/x86/kernel/smp.c::stop_this_cpu() is very similar to 
> > this and could be shared. You could move the stop_this_cpu() function to 
> > arch/x86/kernel/process.c (out of smp.c), so that it can be used by 
> > reboot.c.
> > 
> Yes, this make sense. Here is the patch.

looks good. One small detail:

> +#ifdef CONFIG_X86_LOCAL_APIC
> +	disable_local_APIC();
> +#endif

could you please avoid this #ifdef by putting an inline void function 
for disable_local_APIC() into arch/x86/include/asm/apic.h for the 
!CONFIG_X86_LOCAL_APIC case?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/