Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3

From: Tino Keitel
Date: Thu Nov 06 2008 - 10:32:28 EST

Next message: Ingo Molnar: "Re: [PATCH] Identify which executable object the userspace addressbelongs to. Store thread group leader id, and use it to lookup theaddress in the process's map. We could have looked up the addresson thread's map, but the thread might not exist by the time we arecalled. The process might not exist either, but if you are readingtrace_pipe, that is unlikely."
Previous message: Henrique de Moraes Holschuh: "Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3"
In reply to: Henrique de Moraes Holschuh: "Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3"
Next in thread: Henrique de Moraes Holschuh: "Re: [ibm-acpi-devel] Fan level 7 after resume wit 2.6.28-rc3"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Thu, Nov 06, 2008 at 12:11:21 -0200, Henrique de Moraes Holschuh wrote:

[...]

> and must set it to the higher of (saved, current) using this rule:
>
> fulll-speed > 7 > AUTO.

Maybe the level values should be changed to describe this order.
Currently, it's AUTO (0x80) > full-speed (0x40) > 7. There are already
29(!) functions just for the fan handling, so there should be enough
room for a bit of abstraction. :-) I think it could have the benefit of code
which is easier to read and maintain. Correct me if I'm wrong.

Regards,
Tino
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/