Re: [PATCH 15/16] kvm: x86: set kdump virt_disable function on initialization

[Avi Kivity]

Eric W. Biederman wrote:
> >  
> > +	r = set_virt_disable_func(crash_hardware_disable);
> >     
>
> Can we make this say:
> set_virt_disable_func(kvm_x86_ops->crash_hardware_disable);
>
> So we can avoid going through 2 levels of function pointers?
> I find that a little scary in code that might be running
> at the edge of stack overflow.
>   

Actually, with scheduling disabled we can overflow the stack as much as 
we like.  It will reduce the quality of the dump, but everything ought 
to work.

--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/